refactor: custom 404 page

namecheap · Dec 16, 2021 · fc92894 · fc92894
1 parent f618320
commit fc92894
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 15 deletions.
diff --git a/src/app/index.ts b/src/app/index.ts
@@ -42,7 +42,6 @@ import { IlcIntl } from './IlcIntl';
 import defaultIntlAdapter from './defaultIntlAdapter';
 import { IIlcAppSdk } from './interfaces/IIlcAppSdk';
 import { Render404 } from './interfaces/common';
-import ResponseStatus from './interfaces/ResponseStatus';
 
 export * from './types';
 export * from './GlobalBrowserApi';
@@ -87,16 +86,7 @@ export default class IlcAppSdk implements IIlcAppSdk {
  render404: Render404 = (isCustomPage) => {
  // SSR
  if (this.adapter.setStatus) {
- const status: ResponseStatus = {
- code: 404,
- };
-
- if (isCustomPage) {
- status.headers = {
- ['X-ILC-Override']: 'error-page-content',
- };
- }
- this.adapter.setStatus(status);
+ this.adapter.setStatus(404, isCustomPage);
  return;
  }
 

diff --git a/src/app/interfaces/ResponseStatus.ts b/src/app/interfaces/ResponseStatus.ts
@@ -1,5 +1,5 @@
 type ResponseStatus = {
- code?: number;
+ code: number;
  headers?: Record<string, string>;
 };
 

diff --git a/src/app/interfaces/common.ts b/src/app/interfaces/common.ts
@@ -29,7 +29,7 @@ export interface AppSdkAdapter {
  /** Unique application ID, if same app will be rendered twice on a page - it will get different IDs */
  appId: string;
  intl: IntlAdapter | null;
- setStatus: (data: ResponseStatus) => void;
+ setStatus: (code: number, isCustomPage?: boolean) => void;
  getStatus: () => ResponseStatus | undefined;
 }
 

diff --git a/src/server/IlcSdk.ts b/src/server/IlcSdk.ts
@@ -66,8 +66,14 @@ export class IlcSdk {
  getCurrentPathProps: () => passedProps,
  appId,
  intl: this.parseIntl(req),
- setStatus: (status) => {
- responseStatus = status;
+ setStatus: (code, isCustomPage) => {
+ responseStatus = { code };
+
+ if (isCustomPage) {
+ responseStatus.headers = {
+ ['X-ILC-Override']: 'error-page-content',
+ };
+ }
  },
  getStatus: () => responseStatus,
  };