Skip to content

Commit

Permalink
BREAKING CHANGE: remove deprecated props.appID and exposing Intl class
Browse files Browse the repository at this point in the history
  • Loading branch information
nightnei committed Dec 17, 2021
1 parent f659e44 commit fedbe93
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
6 changes: 0 additions & 6 deletions src/app/interfaces/AppLifecycleFnProps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ export interface AppLifecycleFnProps<RegProps = unknown> extends SingleSpaLifecy
* While for `reqUrl = /a/b/c?d=1` & matched route `/a/b/c` base path will be `/a/b/c`.
*/
getCurrentBasePath: () => string;
/**
* Unique application ID, if same app will be rendered twice on a page - it will get different IDs
*
* @deprecated use `appSdk.appId` instead
*/
appId: string;
/**
* App **MUST** use it to propagate all unhandled errors. Usually it's used in app's adapter.
*/
Expand Down
2 changes: 1 addition & 1 deletion src/server/IlcSdk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class IlcSdk {
originalUri = '/';
}

let tmpResponseData: internalTypes.TmpResponseData = {};
const tmpResponseData: internalTypes.TmpResponseData = {};

const requestData = {
getCurrentReqHost: () => host,
Expand Down

0 comments on commit fedbe93

Please sign in to comment.