chore: e2e tests for 500 error

e2e/codecept.conf.js

@@ -42,6 +42,7 @@ exports.config = {
         newsPage: path.join(__dirname, 'spec', 'pages', 'news.ts'),
         planetsPage: path.join(__dirname, 'spec', 'pages', 'planets.ts'),
         hooksPage: path.join(__dirname, 'spec', 'pages', 'hooks.ts'),
+        common: path.join(__dirname, 'spec', 'pages', 'common.ts'),
     },
     tests: './spec/**/*.spec.e2e.ts',
     name: 'ilc',

e2e/spec/500.spec.e2e.ts

@@ -0,0 +1,39 @@
+Feature('500 error handling');
+
+//region 500 page
+Scenario('Renders 500 page', (I, common: common) => {
+    I.amOnPage(common.url.urlInternalServerError);
+    I.seeInSource(common.textError500);
+    I.seeInSource(common.textErrorId);
+    I.dontSeeInSource(common.textError500ForLocalhostAsIPv4);
+    I.seeInCurrentUrl(common.url.urlInternalServerError);
+});
+Scenario('should open 500 error page when an error happens', async (I, newsPage: newsPage, common: common) => {
+    I.amOnPage(newsPage.url.main);
+    I.waitInUrl(newsPage.url.main, 10);
+    I.waitForElement(newsPage.generateError, 10);
+    I.click(newsPage.generateError);
+    I.seeInSource(common.textError500);
+    I.seeInSource(common.textErrorId);
+    I.dontSeeInSource(common.textError500ForLocalhostAsIPv4);
+    I.seeInCurrentUrl(newsPage.url.main);
+});
+
+Scenario('Renders 500 page for domain 127.0.0.1', (I, common: common) => {
+    I.amOnPage(common.url.localhostAsIPv4 + common.url.urlInternalServerError);
+    I.seeInSource(common.textError500ForLocalhostAsIPv4);
+    I.seeInSource(common.textErrorId);
+    I.dontSeeInSource(common.textError500);
+    I.seeInCurrentUrl(common.url.localhostAsIPv4 + common.url.urlInternalServerError);
+});
+Scenario('should open 500 error page when an error happens for domain 127.0.0.1', async (I, newsPage: newsPage, common: common) => {
+    I.amOnPage(common.url.localhostAsIPv4 + newsPage.url.main);
+    I.waitInUrl(newsPage.url.main, 10);
+    I.waitForElement(newsPage.generateError, 10);
+    I.click(newsPage.generateError);
+    I.seeInSource(common.textError500ForLocalhostAsIPv4);
+    I.seeInSource(common.textErrorId);
+    I.dontSeeInSource(common.textError500);
+    I.seeInCurrentUrl(common.url.localhostAsIPv4 + newsPage.url.main);
+});
+//endregion 500 page

e2e/spec/news.spec.e2e.ts

@@ -36,12 +36,3 @@ Scenario('should open an article page from a direct link', async (I, newsPage: n
     I.seeInCurrentUrl(lastNewsSourceLinkHref);
     I.closeOtherTabs();
 });
-
-Scenario('should open 500 error page when an error happens', async (I, newsPage: newsPage) => {
-    I.amOnPage(newsPage.url.main);
-    I.waitInUrl(newsPage.url.main, 10);
-    I.waitForElement(newsPage.generateError, 10);
-    I.click(newsPage.generateError);
-    I.waitForElement(newsPage.errorId);
-    I.seeInCurrentUrl(newsPage.url.main);
-});

e2e/spec/pages/common.ts

@@ -0,0 +1,8 @@
+export const url = {
+    urlInternalServerError: '/_ilc/500',
+    localhostAsIPv4: 'http://127.0.0.1:8233',
+};
+
+export const textError500 = '<h3>ERROR 500</h3>';
+export const textError500ForLocalhostAsIPv4 = '<h3>500 Internal Server Error on 127.0.0.1</h3>';
+export const textErrorId = 'Error ID:';

e2e/spec/pages/news.ts

@@ -14,7 +14,6 @@ export const newsView = 'body > div#body > div.single-spa-container.news-app > d
 export const newsSources = `${newsView} > div.sources > div.container > ol > li.source`;
 export const bannerHeadline = `${newsView} > div.banner > h1`;
 export const generateError = `${newsView} > div.banner > a`;
-export const errorId = `body > div#error > p:nth-child(3)`;
 export const lastNewsSource = `${newsSources}:last-child`;
 export const lastNewsSourceLink = `${lastNewsSource} > p.action > a`;
 export const newsSourceArticles = `${newsView} > div.container > div.articles > ol > li.article`;

e2e/typings/steps.d.ts

@@ -3,11 +3,12 @@ type peoplePage = typeof import('../spec/pages/people');
 type newsPage = typeof import('../spec/pages/news');
 type planetsPage = typeof import('../spec/pages/planets');
 type hooksPage = typeof import('../spec/pages/hooks');
+type common = typeof import('../spec/pages/common');
 type MockRequestHelper = import('@codeceptjs/mock-request');
 
 declare namespace CodeceptJS {
-  interface SupportObject { I: CodeceptJS.I, peoplePage: peoplePage, newsPage: newsPage, planetsPage: planetsPage, hooksPage: hooksPage }
-  interface CallbackOrder { [0]: CodeceptJS.I; [1]: peoplePage; [2]: newsPage; [3]: planetsPage; [4]: hooksPage }
+  interface SupportObject { I: CodeceptJS.I, peoplePage: peoplePage, newsPage: newsPage, planetsPage: planetsPage, hooksPage: hooksPage, common: common }
+  interface CallbackOrder { [0]: CodeceptJS.I; [1]: peoplePage; [2]: newsPage; [3]: planetsPage; [4]: hooksPage; [5]: common }
   interface Methods extends CodeceptJS.Puppeteer, MockRequestHelper {}
   interface I extends WithTranslation<Methods> {}
   namespace Translation {

ilc/server/errorHandler/ErrorHandler.spec.js

@@ -29,6 +29,7 @@ describe('ErrorHandler', () => {
     });
 
     it('should show 500 error page with an error id', async () => {
+        nock(config.get('registry').address).get('/api/v1/router_domains').reply(200, []);
         nock(config.get('registry').address).get(`/api/v1/template/500/rendered`).reply(200, {
             content:
                 '<html>' +
@@ -59,6 +60,7 @@ describe('ErrorHandler', () => {
     });
 
     it('should send an error message when showing 500 error page throws an error', async () => {
+        nock(config.get('registry').address).get('/api/v1/router_domains').reply(200, []);
         const replyingError = new Error('Something awful happened.');
 
         nock(config.get('registry').address).get(`/api/v1/template/500/rendered`).replyWithError(replyingError.message);

registry/server/seeds/00_cleanup.ts

@@ -10,6 +10,7 @@ export async function seed(knex: Knex): Promise<any> {
             await knex('apps').transacting(trx).truncate();
             await knex('templates').transacting(trx).truncate();
             await knex('shared_props').transacting(trx).truncate();
+            await knex('router_domains').transacting(trx).truncate();
         } finally {
             isMySQL(knex) && await knex.schema.raw('SET FOREIGN_KEY_CHECKS = 1;').transacting(trx);
         }

registry/server/seeds/02_templates.ts

@@ -17,5 +17,11 @@ export async function seed(knex: Knex): Promise<any> {
                 encoding: 'utf8',
             })
         },
+        {
+            name: '500ForLocalhostAsIPv4',
+            content: fs.readFileSync(path.join(__dirname, './data/templates/500ForLocalhostAsIPv4.html'), {
+                encoding: 'utf8',
+            })
+        },
     ]);
 }

registry/server/seeds/06_routerDomains.ts

@@ -0,0 +1,11 @@
+import * as Knex from 'knex';
+
+export async function seed(knex: Knex): Promise<any> {
+    return knex("router_domains").insert([
+        {
+            id: 1,
+            domainName: '127.0.0.1:8233',
+            template500: '500ForLocalhostAsIPv4',
+        },
+    ]);
+}