feat: upgrade to the single-spa 5.6.0 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleh-momot
reviewed
Sep 24, 2020
| @@ -1,4 +1,4 @@ | |||
| import {triggerAppChange} from 'single-spa'; | |||
| import {triggerAppChange} from './navigationEvents'; | |||
There was a problem hiding this comment.
Do we have here events setting up twice?
Look at ilc/client line number 1
There was a problem hiding this comment.
Nope, due to the cache of the imports. Files are executed only once
oleh-momot
reviewed
Sep 24, 2020
| @@ -1,3 +1,4 @@ | |||
| import './client/navigationEvents'; | |||
There was a problem hiding this comment.
It is a little bit tricky
I think that would be easy just to import setupEvents here
There was a problem hiding this comment.
The idea is to have single entry point to this "module"
oleh-momot
approved these changes
Sep 24, 2020
nightnei
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.