Feature/versioning #225
Feature/versioning #225
Conversation
| } | ||
|
|
||
| export function transformSet(entity, operation) { | ||
| if (operation === 'update') { |
There was a problem hiding this comment.
In my opinion, it would be nice to have one object with operations and use it everywhere
because as I see operations are copy/pasted in each of the files
| <TextField sortable={false} source="id" /> | ||
| <TextField sortable={false} source="entity_type" /> | ||
| <TextField sortable={false} source="entity_id" /> | ||
| <FunctionField label="Operation" render={record => record.data && record.data_after ? 'UPDATE' : record.data ? 'DELETE' : 'CREATE'} /> |
There was a problem hiding this comment.
So if you create an object that I mentioned here you could use it here with toUpperCase()
There was a problem hiding this comment.
I think that using here the same variable is a little bit incorrect since it's View with simple textual information which can be changed. So it's better to not mix presentation and logic inside a single variable.
There was a problem hiding this comment.
Yeah, I agree with that
| } | ||
|
|
||
| export interface VersionRowParsed extends VersionRow { | ||
| data: any|null; |
There was a problem hiding this comment.
Are you positive that null is needed here?
There was a problem hiding this comment.
not really, just a silly attempt to express that here we may have random object or null.. Do you know a better typing for this?
No description provided.