feat: support a few domains (404) #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightnei
force-pushed
the
feature/supportFewDomains_404
branch
2 times, most recently
from
288f6d0
to
d3a0147
Compare
nightnei
force-pushed
the
feature/supportFewDomains_404
branch
from
d3a0147
to
4702869
Compare
nightnei
force-pushed
the
feature/supportFewDomains_500
branch
from
ed612be
to
66b0652
Compare
StyleT
approved these changes
Apr 16, 2021
StyleT
suggested changes
Apr 16, 2021
done |
StyleT
reviewed
Apr 19, 2021
e2e/spec/404.spec.e2e.ts
Outdated
|
|
||
| Scenario('Renders (SSR) global 404 page for non-existing ILC route for domain "127.0.0.1:8233"', (I, common: common) => { | ||
| I.amOnPage(common.url.localhostAsIPv4 + '/nonexistent-path'); | ||
| I.waitForText(common.text404NotFound, 10, 'body > div#navbar'); // for "127.0.0.1:8233" inside of navbar will be rendered 404 fragment, like in body |
There was a problem hiding this comment.
I think this test checks nothing... We need to validate that "other" 404 page can be rendered for custom domain.
nightnei
force-pushed
the
feature/supportFewDomains_404
branch
4 times, most recently
from
c5f6207
to
0a467e7
Compare
nightnei
force-pushed
the
feature/supportFewDomains_404
branch
2 times, most recently
from
33a30ee
to
15c0ec0
Compare
nightnei
force-pushed
the
feature/supportFewDomains_404
branch
from
15c0ec0
to
8b24f68
Compare
StyleT
approved these changes
Apr 20, 2021
Base automatically changed from
feature/supportFewDomains_500
to
feature/supportFewDomains_master
April 20, 2021 07:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.