fix: ability to create 404 page via Registry UI #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleT
reviewed
Apr 29, 2021
registry/tests/appRoutes.spec.ts
Outdated
| routeId2 && await request.delete(example.url + routeId2); | ||
| } | ||
| }); | ||
| // it('should not create record with the same orderPos', async () => { |
There was a problem hiding this comment.
it was commented temporary, I have uncommented
StyleT
reviewed
Apr 29, 2021
| return knex.schema.alterTable('routes', table => { | ||
| table.integer('orderPos', 10).nullable().alter(); // alter table don't affect only uniq constraint, so you don't need and it's disallowed to set unique('routes_orderpos_unique') here | ||
| table.string('route', 255).nullable().alter(); | ||
| table.boolean('next').nullable().alter(); |
There was a problem hiding this comment.
Why would you make it null? Just fallback to false
StyleT
reviewed
Apr 29, 2021
| if (isMySQL(knex)) { | ||
| return knex.schema.alterTable('routes', table => { | ||
| table.integer('orderPos', 10).nullable().alter(); // alter table don't affect only uniq constraint, so you don't need and it's disallowed to set unique('routes_orderpos_unique') here | ||
| table.string('route', 255).nullable().alter(); |
There was a problem hiding this comment.
discussed opts:
- rm specialRole & put special ID to route
- keep for now as is
StyleT
reviewed
Apr 29, 2021
| @@ -45,7 +45,7 @@ const commonAppRoute = { | |||
| specialRole: Joi.string().valid('404'), | |||
| orderPos: Joi.number(), | |||
| route: Joi.string().trim().max(255), | |||
| next: Joi.bool().default(false), | |||
| next: Joi.bool(), | |||
There was a problem hiding this comment.
this change is a breaking one
nightnei
force-pushed
the
registryUi404Creating
branch
5 times, most recently
from
ea507a2
to
cd75ab1
Compare
nightnei
force-pushed
the
registryUi404Creating
branch
from
cd75ab1
to
f80ec6e
Compare
StyleT
reviewed
Apr 30, 2021
ilc/server/tailor/fetch-template.js
Outdated
| @@ -24,7 +24,7 @@ module.exports = (configsInjector, newrelic, registryService) => async ( | |||
| throw new Error('Can\'t match route base template to config map'); | |||
| } | |||
|
|
|||
| const routeName = currRoute.route.replace(/^\/(.+)/, '$1'); | |||
| const routeName = currRoute.route?.replace(/^\/(.+)/, '$1'); | |||
There was a problem hiding this comment.
Let's make sure that we always name NR transaction
nightnei
force-pushed
the
registryUi404Creating
branch
from
5b253d8
to
0728dfb
Compare
StyleT
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.