feat: ability to filter ILC Routes in registry by route string #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightnei
suggested changes
May 12, 2021
| @@ -72,6 +73,11 @@ const ListFilter = ({ routerDomain, ...props }) => { | |||
| /> | |||
| : null | |||
| } | |||
| { | |||
| !props.filterValues.showSpecial | |||
| ? <TextInput label="Route prefix" source="routePrefix" alwaysOn resettable/> | |||
There was a problem hiding this comment.
Suggested change
| ? <TextInput label="Route prefix" source="routePrefix" alwaysOn resettable/> | |
| ? <TextInput label="Route" source="route" alwaysOn resettable/> |
There was a problem hiding this comment.
why do you use word "prefix"? I think label can be just "Route" and source="route" or "routePath"
There was a problem hiding this comment.
To emphasise that it is a prefix based search. Ex:
/foo maches: /foo, /foo/ & /foo/bar but doesn't match /test/foo
| @@ -16,6 +16,10 @@ const getAppRoutes = async (req: Request, res: Response) => { | |||
| query.where('routes.route', 'like', `${SPECIAL_PREFIX}%`); | |||
| } else { | |||
| query.whereNot('routes.route', 'like', `${SPECIAL_PREFIX}%`); | |||
|
|
|||
| if (filters.routePrefix !== undefined) { | |||
| query.where('routes.route', 'like', `${filters.routePrefix}%`) | |||
There was a problem hiding this comment.
and here it's better to allow whole search with "%" at the beginning
Suggested change
| query.where('routes.route', 'like', `${filters.routePrefix}%`) | |
| query.where('routes.route', 'like', `%${filters.route}%`) |
nightnei
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.