update protoc-gen-go and split go gRPC plugin to protoc-gen-go-grpc #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ido-namely
commented
Aug 24, 2022
| echo " --go-package-map Map proto imports to go import paths" | ||
| echo " --go-plugin-micro Replaces the Go gRPC plugin with go-micro" | ||
| echo " --go-proto-validator Generate Go proto validations - see https://github.com/mwitkow/go-proto-validators" | ||
| echo " --go-grpc-require-unimplemented-servers Generate Go gRPC service with unimplemented server for future compatability- https://github.com/grpc/grpc-go/tree/master/cmd/protoc-gen-go-grpc#future-proofing-services" |
There was a problem hiding this comment.
this is the actual addition, the rest are just tabs
abe545
approved these changes
Aug 26, 2022
klvmungai
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from deprecated protoc-gen-go, which included the gRPC plugin, to the new version - https://pkg.go.dev/google.golang.org/protobuf/cmd/protoc-gen-go.
This means we need to separately install and invoke the grpc plugin - protoc-gen-go-grpc
See more info here - golang/protobuf#1070 (comment)
--go-grpc-require-unimplemented-serversPlease note that this still introduces somewhat of a breaking change, since the plugin now generates its code in a separate file (see examples used in the test file of this PR).
This version is currently available in docker image namely/protoc-all:1.47_3-rc.1
Credits: inspired by @caseybarker PR - #290