Use buffer prop to calculate when to redraw canvas #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when to redraw was statically set to 0.5x the displayed interval. Most likely this is a bug as it should redraw when only half of the configured buffer size remains outside the viewport.
LudvigHz
force-pushed
the
buffer-redraw
branch
from
e88961f to
b9c2819
Compare
|
@LudvigHz thank you, I am curious, did you get a chance to test out the new beta release with your app? have you seen any issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #913
Overview of PR
The README states that the canvas should redraw when there is 1/2 of the buffer left off-screen on
any side of the viewport. However, the code calculates the redraw based on 1/2 of the viewport and
not the buffer. This PR fixes this. This means that for buffers larger than the default, we
re-render way less often, providing for better performance with large timelines. As it is now, for
many tasks (~1000) the canvas continuously re-renders when scrolling, and the rendering cannot keep
up with scrolling, forcing the items to appear as they jump around a lot.