-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fix typos and improve language in README.md #1669
doc: Fix typos and improve language in README.md #1669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, sometimes we need long description even for an oneliner. :)
README.md
Outdated
In addition, function arguments and return values can be saved and shown later. | ||
|
||
It supports multi-process and/or multi-threaded applications. With root | ||
It supports multiprocess and/or multithreaded applications. With root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I still prefer having a dash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, change is reverted now.
03235cf
to
788b30a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. Now it looks good. But can you please add your sign-off in the commit message?
Also, I think the commit subject can have the 'doc:' prefix instead of 'README.md:'. |
7a179da
to
518ee16
Compare
518ee16
to
9738568
Compare
@namhyung Thanks for the approval, and I updated the commit message as requested. You can merge now. |
It'd be nice to have your real email address in the sign-off line. |
Hi @bernhardkaindl, good to see you back here again.
@namhyung mentioned the line below.
I don't think |
- Missing commas after conjunctive/linking adverbs: addition,also. - Use a comma before 'so' if it connects two independent clauses unless they are closely connected and short (but aren't short) - Use "this info" instead of "it" for clarity - "inside of": This phrase is redundant. Consider using 'inside' - The verb 'set up' is spelled as two words. The noun 'setup' is spelled as one. Signed-off-by: Bernhard Kaindl <bernhardkaindl7@gmail.com>
9738568
to
b806877
Compare
@honggyukim @namhyung
However, as I don't want to argue on that a lot, I updated the commit. |
Yeah, it's from old-style email conversations in the kernel community where I used to work on. Probably not needed for github based workflow, but I still prefer seeing real email addresses. Thanks for the update! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this is the first PR where the description turned out to be much longer than the diff in the "Files changed" view is. ;-)
These issues were found by using these LanguageTool extensions for VS Code:
Below are the warning messages from LanguageTool / LTeX extension.
:)
Also, I reworded a sentence which included the sequence "the write" which it warned about with this explanation:
"After 'The', the verb 'write' doesn't fit. If 'write' is the first word in a compound adjective, use a hyphen between the two words. Using the verb 'write' as a noun may be non-standard."
Also, it found a typo and words which need to be capitalized, like Chrome (The proper noun 'Chrome' (= software from Google) needs to be capitalized) which I fixed as well.
:)