dynamic: x86_64: refactor patch code #1745
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the functions where uftrace already injected a call to a trampoline. Signed-off-by: Clément Guidi <cguidi@ciena.com>
Refactor for more clarity. Signed-off-by: Clément Guidi <cguidi@ciena.com>
Refactor 'patch_code' so it can later be used at runtime. Co-authored-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com> Signed-off-by: Clément Guidi <cguidi@ciena.com>
Check if instruction at a given address is ENDBR64. Signed-off-by: Clément Guidi <cguidi@ciena.com>
This was referenced Jul 7, 2023
namhyung
reviewed
Jul 10, 2023
| /* | ||
| * We fill the remaining part of the patching region with nops. | ||
| * | ||
| * 0x0: int3 |
There was a problem hiding this comment.
Where did you update the first byte?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fifth PR in a series of patches intended to bring runtime dynamic tracing on x86_64 to uftrace.
We refactor code for clarity and prepare
patch_codeto be used at runtime.Related: #1698