Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Add make install in Dockerfile when test=yes #1787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

3godhalmang
Copy link

Added code because docker file is missing 'make install' in case test=yes

Alpine and Arch could not be added due to the following error
I'm going to give a try to fix these problems.

Alpine(only if test =yes)
[Makefile:49: test_unit] Segmentation fault (core dumped)

Arch(for both condition)
no matching manifest for linux/arm64/v8 in the manifest list entries

Added code because docker file is missing 'make install' in case test=yes

Signed-off-by: Sungho Park <powdownow@gmail.com>
@namhyung
Copy link
Owner

It seems the failure in Alpine is not related to make install. Also I'm not sure if we really want to run make install for tests.

@3godhalmang
Copy link
Author

It would be better to include the make install process for tests
because there was a make install fail problem with PANDOC in 2.0 and earlier.

related: #1766, #1783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants