Add support for AES-CCM #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
JKRhb
reviewed
Aug 22, 2024
|
This PR should now be ready for review. Aside from the added features (AES-CCM and partial IVs), I have also applied some (new?) clippy suggestions for old code in 4b33e00. |
falko17
requested changes
Aug 27, 2024
pulsastrix
added a commit
that referenced
this pull request
Aug 27, 2024
Co-authored-by: Falko Galperin <10247603+falko17@users.noreply.github.com>
pulsastrix
added a commit
that referenced
this pull request
Aug 27, 2024
pulsastrix
added a commit
that referenced
this pull request
Aug 27, 2024
pulsastrix
added a commit
that referenced
this pull request
Aug 27, 2024
Co-authored-by: Falko Galperin <10247603+falko17@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for all AES-CCM variants to the COSE module and both cryptographic backends.
Part of #18.
Additionally, this PR makes some smaller optimizations to the AES-GCM code (saving one copy operation and making it consistent with the AES-CCM code) and adds support for partial IVs.