feat: flag to enable white bg for videos

namidaco · Jul 22, 2024 · d1cdc2e · d1cdc2e
1 parent eb651ef
commit d1cdc2e
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 8 deletions.
diff --git a/lib/controller/settings.youtube.dart b/lib/controller/settings.youtube.dart
@@ -9,15 +9,18 @@ class _YoutubeSettings with SettingsFileWriter {
   int addToPlaylistsTabIndex = 0;
   bool markVideoWatched = true;
   InnertubeClients? innertubeClient;
+  bool whiteVideoBGInLightMode = false;
 
   void save({
     int? addToPlaylistsTabIndex,
     bool? markVideoWatched,
     InnertubeClients? innertubeClient,
+    bool? whiteVideoBGInLightMode,
   }) {
     if (addToPlaylistsTabIndex != null) this.addToPlaylistsTabIndex = addToPlaylistsTabIndex;
     if (markVideoWatched != null) this.markVideoWatched = markVideoWatched;
     if (innertubeClient != null) this.innertubeClient = innertubeClient;
+    if (whiteVideoBGInLightMode != null) this.whiteVideoBGInLightMode = whiteVideoBGInLightMode;
     _writeToStorage();
   }
 
@@ -41,6 +44,7 @@ class _YoutubeSettings with SettingsFileWriter {
       addToPlaylistsTabIndex = json['addToPlaylistsTabIndex'] ?? addToPlaylistsTabIndex;
       markVideoWatched = json['markVideoWatched'] ?? markVideoWatched;
       innertubeClient = InnertubeClients.values.getEnum(json['innertubeClient']);
+      whiteVideoBGInLightMode = json['whiteVideoBGInLightMode'] ?? whiteVideoBGInLightMode;
     } catch (e) {
       printy(e, isError: true);
     }
@@ -53,6 +57,7 @@ class _YoutubeSettings with SettingsFileWriter {
         'addToPlaylistsTabIndex': addToPlaylistsTabIndex,
         'markVideoWatched': markVideoWatched,
         'innertubeClient': innertubeClient?.convertToString,
+        'whiteVideoBGInLightMode': whiteVideoBGInLightMode,
       };
 
   Future<void> _writeToStorage() => writeToStorage();

diff --git a/lib/controller/video_controller.dart b/lib/controller/video_controller.dart
@@ -140,14 +140,21 @@ class VideoController {
     bool? setOrientations,
   }) async {
     final aspect = Player.inst.videoPlayerInfo.value?.aspectRatio;
+    Widget videoControls = NamidaVideoControls(
+      key: VideoController.inst.videoControlsKeyFullScreen,
+      isLocal: isLocal,
+      onMinimizeTap: NamidaNavigator.inst.exitFullScreen,
+      showControls: true,
+      isFullScreen: true,
+    );
+    if (settings.youtube.whiteVideoBGInLightMode && namida.context?.isDarkMode == false) {
+      videoControls = ColoredBox(
+        color: Colors.white,
+        child: videoControls,
+      );
+    }
     await NamidaNavigator.inst.toggleFullScreen(
-      NamidaVideoControls(
-        key: VideoController.inst.videoControlsKeyFullScreen,
-        isLocal: isLocal,
-        onMinimizeTap: NamidaNavigator.inst.exitFullScreen,
-        showControls: true,
-        isFullScreen: true,
-      ),
+      videoControls,
       setOrientations: setOrientations ?? (aspect == null ? true : aspect > 1),
     );
   }

diff --git a/lib/ui/widgets/settings/youtube_settings.dart b/lib/ui/widgets/settings/youtube_settings.dart
@@ -569,6 +569,11 @@ class __YTFlagsOptionsState extends State<_YTFlagsOptions> {
                   child: Text(settings.youtube.innertubeClient?.name ?? lang.DEFAULT)),
               onTap: () {},
             ),
+            CustomSwitchListTile(
+              value: settings.youtube.whiteVideoBGInLightMode,
+              onChanged: (isTrue) => setState(() => settings.youtube.save(whiteVideoBGInLightMode: !isTrue)),
+              title: 'white_video_bg_in_light_mode'.toUpperCase(),
+            ),
           ],
         ),
       ),

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,7 +1,7 @@
 name: namida
 description: A Beautiful and Feature-rich Music Player, With YouTube & Video Support Built in Flutter
 publish_to: "none"
-version: 3.5.7-beta+240722227
+version: 3.5.8-beta+240722230
 
 environment:
   sdk: ">=3.4.0 <4.0.0"