Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NC-5747: Align method with web-sdk #353

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NC-5747: Align method with web-sdk #353

wants to merge 2 commits into from

Conversation

cp-sumi-k
Copy link
Contributor

@cp-sumi-k cp-sumi-k commented Oct 10, 2024 •
edited
Loading

  • Make field required in isEntitlementActive
  • Add buySkuComplete method in NamiPaywallManager

@cp-sumi-k cp-sumi-k requested a review from namidan October 10, 2024 10:44
namidan
namidan requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@namidan namidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like removeAllListeneres was only added to the Android bridge, and not iOS bridge or NamiPaywallManager ts

@cp-sumi-k
Copy link
Contributor Author

Looks like removeAllListeneres was only added to the Android bridge, and not the iOS bridge or NamiPaywallManager ts

It was by mistake. I guess we don't need to add that method in RN as mobile SDKs are handling this internally

@cp-sumi-k
Copy link
Contributor Author

@namidan For now, kept other buySkuComplete methods to avoid backward compatibility crashes, should we remove them now?

@cp-sumi-k cp-sumi-k requested a review from namidan November 15, 2024 12:41
@cp-sumi-k cp-sumi-k force-pushed the nc-5747-align-method-with-web-sdk branch from ec18cd0 to 10452b0 Compare November 18, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namidan namidan Awaiting requested review from namidan

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cp-sumi-k @namidan