Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot preview harnesses with images #3

Closed
robotskirts opened this issue Nov 10, 2023 · 5 comments
Closed

[Bug] Cannot preview harnesses with images #3

robotskirts opened this issue Nov 10, 2023 · 5 comments
Milestone

Comments

@robotskirts
Copy link

Most of my harnesses have images in them implemented exactly as they are in example 08 https://github.com/wireviz/WireViz/blob/master/examples/readme.md#example-08

The Wireviz Preview throws an error that it's looking for the image file in a path relative to the output directory instead of relative to the input yml. e.g. output/resources/stereo-phone-plug-TRS.png instead of the correct resources/stereo-phone-plug-TRS.png

I tested demo02.yml on this MacOS install of VS Code and it worked fine when their weren't images.

@robotskirts robotskirts changed the title [Test] Check harasses with images [Test] Check harnesses with images Nov 10, 2023
@nanangp
Copy link
Owner

nanangp commented Nov 10, 2023

Oh thanks. In hindsight, I probably should have run it against the full wireviz example suite.

This, unfortunately, seems to be a wireviz limitation. We get the error just running wireviz "ex08.yml" -o "output/ex08"
I'll change the extension back to not outputting to a subdirectory for now - which means cluttering the input dir, but better than not working i guess?

@nanangp nanangp changed the title [Test] Check harnesses with images [Bug] Cannot preview harnesses with images Nov 10, 2023
@robotskirts
Copy link
Author

robotskirts commented Nov 10, 2023

It might be fixed in the dev branch already which I've never used. wireviz/WireViz#284 (comment)
I just use a tasks.json task to run wireviz now so I was already cluttering the input directory... probably because of this exact bug, I just don't remember :)

@nanangp
Copy link
Owner

nanangp commented Nov 10, 2023

Yeah, actually I remember seeing that when going through their closed issues some time ago. It's unfortunate that dev has been around for more than 2, years and doesn't seem any closer to making it to release. It has a number of good stuff that we could really use here.

@nanangp
Copy link
Owner

nanangp commented Nov 17, 2023

Hmmh, this is more annoying than it should be. Just found out the WebView in VSCode won't show external images inside an SVG (also tested on every other SVG Viewer extensions in the marketplace). I'll put in some workarounds in config, for people that want to use images.

@nanangp
Copy link
Owner

nanangp commented Nov 17, 2023

Closing this for now. See the Limitations section in README.md.

We'll revisit when/if the dev branch of WireViz makes it into stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants