-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Cannot preview harnesses with images #3
Comments
Oh thanks. In hindsight, I probably should have run it against the full wireviz example suite. This, unfortunately, seems to be a wireviz limitation. We get the error just running |
It might be fixed in the dev branch already which I've never used. wireviz/WireViz#284 (comment) |
Yeah, actually I remember seeing that when going through their closed issues some time ago. It's unfortunate that |
Hmmh, this is more annoying than it should be. Just found out the WebView in VSCode won't show external images inside an SVG (also tested on every other SVG Viewer extensions in the marketplace). I'll put in some workarounds in config, for people that want to use images. |
Closing this for now. See the Limitations section in README.md. We'll revisit when/if the |
Most of my harnesses have images in them implemented exactly as they are in example 08 https://github.com/wireviz/WireViz/blob/master/examples/readme.md#example-08
The Wireviz Preview throws an error that it's looking for the image file in a path relative to the output directory instead of relative to the input yml. e.g. output/resources/stereo-phone-plug-TRS.png instead of the correct resources/stereo-phone-plug-TRS.png
I tested demo02.yml on this MacOS install of VS Code and it worked fine when their weren't images.
The text was updated successfully, but these errors were encountered: