Speed up/enhance setup-chromedrive.sh #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention that I have run this privately and it works fine, though I didn't test specifying a version. |
nanasess
approved these changes
Aug 6, 2023
|
LGTM, Thanks for your contribution! |
|
@rasa v2.2.0 has been released. Thank you for your exellent contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only download URLs once
Only call apt-get install once, if needed
Install Chrome on Debian and derivatives
Remove dependency on bc
Remove duplicate code
Fix all shellcheck issues
Add debug output, where applicable
Edit: Replace
echo foo | bars withbar <<<foo