-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commas every 3 digits to the left #1
Comments
Perhaps we should use JavaScript's .toLocaleString() to return language-sensitive number representations in the UI? |
This has been added to my PR here, but copy/pasting still needs to be more thoroughly tested. In my own testing (Windows Chrome), the sending amount field already strips pasted commas, but I'm not sure what the behavior is across different locales (e.g. EU where commas and decimals are flipped) |
modified: src/app/app.component.html
Ah that's much better, thanks. Pasting into Natrium results in "," being replaced with "." Should that be considered a Natrium problem? |
In Natrium, commas are stripped while decimals are supported, while in NyanoWallet both commas and decimals are stripped (to focus on sending "whole Nyano") |
It's going to be hard to read big numbers and easy to make order-of-magnitude mistakes. Can commas be added? More on this concept.
A concern is that it might interfere with copying and pasting.
The text was updated successfully, but these errors were encountered: