Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #598

Merged
merged 9 commits into from
Oct 16, 2017
Merged

Update docs #598

merged 9 commits into from
Oct 16, 2017

Conversation

rgoomar
Copy link
Contributor

@rgoomar rgoomar commented Oct 15, 2017

Helps with #503

Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

commands/info.go Outdated
@@ -16,7 +16,7 @@ var (

// InfoCmd ...
InfoCmd = &cobra.Command{
Use: "info",
Use: "info [local | dry-run | remote-alias]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the remote-alias portion of this has yet to be implemented

@@ -15,7 +15,11 @@ var (
LoginCmd = &cobra.Command{
Use: "login",
Short: "Authenticate your nanobox client with your nanobox.io account.",
Long: ``,
Long: `
Authenticate with your nanobox account by passing the username and password in or using the following environment variables:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the leading spaces on these 3 lines, so the output isn't pushed out so much.

@@ -27,7 +27,7 @@ remote, live applications created with Nanobox.

// RemoteAddCmd ...
RemoteAddCmd = &cobra.Command{
Use: "add",
Use: "add <team-name>/<app-name> [remote-alias]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since team-name is technically optional, can you update this to be [team-name/]<app-name> [remote-alias]

@rgoomar
Copy link
Contributor Author

rgoomar commented Oct 16, 2017

@glinton should be good to go now

@glinton glinton merged commit 735949f into nanobox-io:master Oct 16, 2017
@rgoomar rgoomar deleted the update-docs branch October 17, 2017 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants