Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pool_connection () for stopped bootstrap or bootstrap_client #1500

Merged
merged 2 commits into from
Dec 29, 2018

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Dec 26, 2018

Fixes #1496

@SergiySW SergiySW self-assigned this Dec 26, 2018
@zhyatt
Copy link
Collaborator

zhyatt commented Dec 27, 2018

@SergiySW Can you find out when this issue first showed up? And also if anything we have done recently has made this worse? Trying to evaluate where to include this fix.

@SergiySW
Copy link
Contributor Author

SergiySW commented Dec 27, 2018

Ptobably it's related to lazy_bootstrap implementation (#1332) especially https://github.com/nanocurrency/raiblocks/blob/master/rai/node/bootstrap.cpp#L594
But it also happening with previous versions or with disabled lazy bootstrap, just less often.
Also bulk_pull_client and pulk_push_server now more often drop connections

@zhyatt
Copy link
Collaborator

zhyatt commented Dec 27, 2018

Looking at including this in V18 unless there is an urgency to push earlier.

@SergiySW SergiySW added the bug label Dec 27, 2018
@zhyatt zhyatt added this to the V18.0 milestone Dec 28, 2018
Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that we respect the request to stop using a connection and close it as soon as it goes out of scope -- looks good to me !

@SergiySW SergiySW changed the base branch from releases/v17 to master December 28, 2018 20:55
@rkeene rkeene merged commit 250ffac into nanocurrency:master Dec 29, 2018
@zhyatt zhyatt modified the milestones: V18.0, V17.1 Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants