Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove else and always flush if over config.json active_elections_size #2116

Merged
merged 1 commit into from
Jul 3, 2019
Merged

remove else and always flush if over config.json active_elections_size #2116

merged 1 commit into from
Jul 3, 2019

Conversation

argakiig
Copy link
Contributor

@argakiig argakiig commented Jul 2, 2019

No description provided.

@argakiig argakiig added the bug label Jul 2, 2019
@argakiig argakiig added this to the V19.0 milestone Jul 2, 2019
@argakiig argakiig requested a review from SergiySW July 2, 2019 17:14
@argakiig argakiig self-assigned this Jul 2, 2019
@argakiig argakiig merged commit af7ae2f into nanocurrency:master Jul 3, 2019
@argakiig argakiig deleted the roots_size branch July 3, 2019 03:59
@SergiySW SergiySW mentioned this pull request Jul 3, 2019
Merged
@zhyatt zhyatt mentioned this pull request Jul 3, 2019
Closed
@clemahieu
Copy link
Contributor

Can we get a test that will trigger the incorrect behavior.

argakiig pushed a commit that referenced this pull request Jul 5, 2019
remove else and always flush if over config.json active_elections_size (
65874ce 
#2116)
argakiig pushed a commit that referenced this pull request Jul 10, 2019
test validating #2116 (#2138)
df77533 
* test validating #2116

* whitespace formatting

* typo and deadline.set
argakiig pushed a commit that referenced this pull request Jul 10, 2019
test validating #2116 (#2138)
970cafe 
* test validating #2116

* whitespace formatting

* typo and deadline.set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@SergiySW SergiySW SergiySW approved these changes

@cryptocode cryptocode cryptocode approved these changes

Assignees

@argakiig argakiig

Labels
bug
Projects
None yet
Milestone
V19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@argakiig @clemahieu @wezrule @SergiySW @cryptocode