Fix open blocks not getting activated through dependencies #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression introduced by nanocurrency#2778 Adds two tests to ensure proper behavior: - `election.dependencies_open_link` which covers the fix by itself - `dependency_graph_frontier`, a more complex test ensuring we can walk down a more complex graph before confirming it from the bottom up
SergiySW
previously approved these changes
Jun 3, 2020
wezrule
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression introduced by #2778
Adds two tests to ensure proper behavior:
election.dependencies_open_linkwhich covers the fix by itselfnode.dependency_graph_frontier, a more complex test ensuring we can walk down a more complex graph before confirming it from the bottom up. This test is a bit long at 8 to 10 seconds (same with sanitizers though), but seems like a strong addition.