Sequential elections #2801
Merged
Sequential elections #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
quality improvements
Building off the multi-level election controls added in nanocurrency#2785, this PR changes the block processing behavior to only start an election if the block's ancestors are confirmed. - There is a superlinear usage of resources the more elections are active for the same chain, which is now prevented. - On confirming an election, the successors (in the same chain and destination chain for sends) are activated (functionality from nanocurrency#2785). - Frontier confirmation works as the fallback behavior, for bootstraps and nodes restarting after getting blocks. Backtracking (nanocurrency#2778) later starts the bottom-most election if unable to confirm the frontier.
guilhermelawless
force-pushed
the
sequential_elections
branch
from
cdf0582 to
bbf8158
Compare
wezrule
approved these changes
Jun 5, 2020
SergiySW
approved these changes
Jun 5, 2020
clemahieu
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off the multi-level election controls added in #2785, this PR changes the block processing behavior to only start an election if the block's ancestors are confirmed.