Ignore selected peers #4413
Draft
Ignore selected peers #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
reviewed
Feb 1, 2024
|
We should also have an affirmative test that shows the ip blocking works. |
|
I've moved the logic to the tcp_listener::on_connection function. I will try to add some unit tests next |
clemahieu
reviewed
Feb 1, 2024
| @@ -136,6 +137,13 @@ void nano::transport::tcp_listener::on_connection (std::function<bool (std::shar | |||
| [this_l, new_connection, cbk = std::move (callback)] (boost::system::error_code const & ec_a) mutable { | |||
| this_l->evict_dead_connections (); | |||
|
|
|||
| if (this_l->is_ip_blocked (new_connection->remote.address ())) | |||
| { | |||
| this_l->node.logger.info (nano::log::type::tcp_listener, "Connection refused from blocked IP: {}", new_connection->remote_endpoint ().address ().to_string ()); | |||
There was a problem hiding this comment.
I think this should remain a debug log as it could be high-volume.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional list of ip addresses that a node operator wants to ignore. The peers are inserted in the config file as "blocked_peers"
Both ip v4 and v6 address formats are supported and can be mixed. Example:
blocked_peers = ["::ffff:10.0.0.1", "192.168.0.1"]
This could be useful for blocking malicious nodes.