Cleaner daemon stopping #4560
Merged
Cleaner daemon stopping #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
reviewed
Apr 14, 2024
pwojcikdev
force-pushed
the
networking-fixes/daemon-latch-rebased
branch
from
1fa4b3a to
29e7218
Compare
clemahieu
approved these changes
Apr 14, 2024
dsiganos
reviewed
Apr 17, 2024
| nano::signal_handler_impl = [&ioc] () { | ||
| nano::signal_manager sigman; | ||
|
|
||
| auto signal_handler = [&ioc] (int signum) { | ||
| ioc.stop (); |
There was a problem hiding this comment.
This looks wrong, although I do not know if we are still using the load_test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current daemon stopping logic is unnecessarily convoluted and relies on io context being stopped first, which is problematic. This should unblock #4523. I expect this will also make it easier to move io context into the node.
There are no CI tests that ensure proper daemon operation, but by testing it manually it seems to work fine. I'll see if I can implement such test and submit it in another PR.