Fix Test request_aggregator.one_update
#4615
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 12, 2024 11:52
…will always be 2 eventually instead of 1
pwojcikdev
reviewed
May 13, 2024
…ould be bundled into one vote
gr0vity-dev
force-pushed
the
prs/fix_request_aggregator-one_update
branch
from
6583723 to
6783fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
request_aggregator.one_updateis failing intermittently (1/100 cases) becausenode.stats.count(nano::stat::type::requests, nano::stat::detail::requests_generated_votes))is 2 instead of expected 1. However it will eventually always be 2.I changed the test-case accordingly, but maybe there is un underlying issue if
requests_generated_votesshould be 1 rather than 2.I also noticed that
node.aggregator.empty ()is not guaranteed to be true immediately in about 1/2000 cases for me.