Disallow database operations on network IO threads #4772
+55
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
prevent-db-on-io-threads
branch
from
3544eeb
to
f283da3
Compare
pwojcikdev
force-pushed
the
prevent-db-on-io-threads
branch
from
f283da3
to
3d72ae9
Compare
Test Results for Commit 3d72ae9Pull Request 4772: Results Test Case Results
Last updated: 2024-10-27 17:29:58 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing synchronous disk IO on network IO threads can introduce very long delays, blocking network thread pool. This adds an assert that will detect this.
Currently this doesn't pass tests nicely because legacy bootstrap trips the assert.