Add GetCustomAttributes method to MemberInfo and derived classes

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
nanoframework · Sep 27, 2018 · 4f4d567 · 4f4d567
1 parent 3c23f49
commit 4f4d567
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 3 deletions.
diff --git a/source/CoreLibrary.nfproj b/source/CoreLibrary.nfproj
@@ -21,6 +21,7 @@
     <OutputName>mscorlib</OutputName>
     <IsCoreAssembly>true</IsCoreAssembly>
     <IsMscorlib>true</IsMscorlib>
+    <DefineConstants>$(DefineConstants);</DefineConstants>
     <TargetFrameworkVersion>v1.0</TargetFrameworkVersion>
     <DocumentationFile>bin\$(Configuration)\mscorlib.xml</DocumentationFile>
   </PropertyGroup>
@@ -378,4 +379,4 @@
       <ProjectConfigurationsDeclaredAsItems />
     </ProjectCapabilities>
   </ProjectExtensions>
-</Project>
+</Project>
diff --git a/source/System/Reflection/ConstructorInfo.cs b/source/System/Reflection/ConstructorInfo.cs
@@ -6,8 +6,8 @@
 
 namespace System.Reflection
 {
-    using System;
     using Runtime.CompilerServices;
+    using System;
 
     /// <summary>
     /// Discovers the attributes of a class constructor and provides access to constructor metadata.
@@ -38,5 +38,15 @@ public override MemberTypes MemberType
         [Diagnostics.DebuggerHidden]
         [MethodImpl(MethodImplOptions.InternalCall)]
         public extern Object Invoke(Object[] parameters);
+
+        /// <summary>
+        /// When overridden in a derived class, returns an array of all custom attributes applied to this member.
+        /// </summary>
+        /// <param name="inherit">true to search this member's inheritance chain to find the attributes; otherwise, false. This parameter is ignored for properties and events.</param>
+        /// <returns>An array that contains all the custom attributes applied to this member, or an array with zero elements if no attributes are defined.</returns>
+        /// <remarks>This method is not implemented in nanoFramework.</remarks>
+        /// <exception cref="NotImplementedException"/>
+        [MethodImpl(MethodImplOptions.InternalCall)]
+        public extern override object[] GetCustomAttributes(bool inherit);
     }
 }
diff --git a/source/System/Reflection/FieldInfo.cs b/source/System/Reflection/FieldInfo.cs
@@ -6,8 +6,8 @@
 
 namespace System.Reflection
 {
-    using System;
     using Runtime.CompilerServices;
+    using System;
 
     /// <summary>
     /// Discovers the attributes of a field and provides access to field metadata.
@@ -59,6 +59,17 @@ public abstract Type FieldType
         [Diagnostics.DebuggerHidden]
         [MethodImpl(MethodImplOptions.InternalCall)]
         public virtual extern void SetValue(Object obj, Object value);
+
+        /// <summary>
+        /// When overridden in a derived class, returns an array of all custom attributes applied to this member.
+        /// </summary>
+        /// <param name="inherit">true to search this member's inheritance chain to find the attributes; otherwise, false. This parameter is ignored for properties and events.</param>
+        /// <returns>An array that contains all the custom attributes applied to this member, or an array with zero elements if no attributes are defined.</returns>
+        /// <remarks>This method is not implemented in nanoFramework.</remarks>
+        /// <exception cref="NotImplementedException">This method is not implemente.</exception>
+        /// <exception cref="NotImplementedException"/>
+        [MethodImpl(MethodImplOptions.InternalCall)]
+        public extern override object[] GetCustomAttributes(bool inherit);
     }
 }
 

diff --git a/source/System/Reflection/MemberInfo.cs b/source/System/Reflection/MemberInfo.cs
@@ -46,5 +46,12 @@ public abstract Type DeclaringType
         {
             get;
         }
+
+        /// <summary>
+        /// When overridden in a derived class, returns an array of all custom attributes applied to this member.
+        /// </summary>
+        /// <param name="inherit">true to search this member's inheritance chain to find the attributes; otherwise, false. This parameter is ignored for properties and events.</param>
+        /// <returns>An array that contains all the custom attributes applied to this member, or an array with zero elements if no attributes are defined.</returns>
+        public abstract object[] GetCustomAttributes(bool inherit);
     }
 }
diff --git a/source/System/Reflection/RuntimeMethodInfo.cs b/source/System/Reflection/RuntimeMethodInfo.cs
@@ -17,5 +17,8 @@ public override extern Type ReturnType
             [MethodImpl(MethodImplOptions.InternalCall)]
             get;
         }
+
+        [MethodImpl(MethodImplOptions.InternalCall)]
+        public override extern object[] GetCustomAttributes(bool inherit);
     }
 }
diff --git a/source/System/RuntimeType.cs b/source/System/RuntimeType.cs
@@ -80,5 +80,7 @@ public override extern Type BaseType
         [MethodImpl(MethodImplOptions.InternalCall)]
         public override extern Type GetElementType();
 
+        [MethodImpl(MethodImplOptions.InternalCall)]
+        public override extern object[] GetCustomAttributes(bool inherit);
     }
 }