Update comment on Random class

- This is to clarify that some targets can have a pseudo-random software generator or a hardware random generator - Add pragma to remove warning about non used field - Fix Nuget solutions
nanoframework · Mar 12, 2018 · f9c5a4d · f9c5a4d
1 parent 70ddacb
commit f9c5a4d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/source/System/Random.cs b/source/System/Random.cs
@@ -9,16 +9,25 @@
 namespace System
 {
     /// <summary>
-    /// Represents a pseudo-random number generator, a device that produces a
+    /// Represents a random number generator, a device that produces a
     /// sequence of numbers that meet certain statistical requirements for
     /// randomness.
     /// </summary>
+    /// <remarks>
+    /// Depending on the platform it can be a software dependent pseudo-random generator algorithm 
+    /// or a hardware random generator providing true random numbers.
+    /// </remarks>
     public class Random
     {
+        // this field needs to be here because it's required for the native implementation
+#pragma warning disable 0169
         private object _random;
+#pragma warning restore 0169
+
 
         /// <summary>
-        /// Initializes a new instance of the Random class, using a time-
+        /// Initializes a new instance of the Random class. 
+        /// If the provider is algorithm based the initialisation is performed using a time-
         /// dependent default seed value.
         /// </summary>
         [MethodImpl(MethodImplOptions.InternalCall)]

diff --git a/source/nanoFramework.CoreLibrary.Nuget.sln b/source/nanoFramework.CoreLibrary.Nuget.sln
@@ -7,11 +7,6 @@ Project("{FF286327-C783-4F7A-AB73-9BCBAD0D4460}") = "nanoFramework.CoreLibrary",
 EndProject
 Project("{FF286327-C783-4F7A-AB73-9BCBAD0D4460}") = "nanoFramework.CoreLibrary.DELIVERABLES", "Nuget.CoreLibrary.DELIVERABLES\nanoFramework.CoreLibrary.DELIVERABLES.nuproj", "{8FD36AD6-387C-48F0-A695-52D9149216FB}"
 EndProject
-Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".nuget", ".nuget", "{7A280E23-EB14-4791-B9E7-4ECB6C84D7B8}"
-	ProjectSection(SolutionItems) = preProject
-		packages.config = packages.config
-	EndProjectSection
-EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU

diff --git a/source/nanoFramework.CoreLibrary.sln b/source/nanoFramework.CoreLibrary.sln
@@ -5,6 +5,11 @@ VisualStudioVersion = 15.0.27130.2010
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{11A8DD76-328B-46DF-9F39-F559912D0360}") = "CoreLibrary", "CoreLibrary.nfproj", "{BE7B95D5-087C-45F8-8197-4B438BEDFE11}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".nuget", ".nuget", "{7A280E23-EB14-4791-B9E7-4ECB6C84D7B8}"
+	ProjectSection(SolutionItems) = preProject
+		packages.config = packages.config
+	EndProjectSection
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU