Fix infinite loop in Append(object value) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ishvedov, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
|
|
|
Nice catch! 👏 💯 |
josesimoes
reviewed
May 28, 2018
source/System/Text/StringBuilder.cs
Outdated
| @@ -364,7 +364,7 @@ public StringBuilder Append(long value) | |||
| /// <returns>A reference to this instance after the append operation has completed.</returns> | |||
| public StringBuilder Append(object value) | |||
| { | |||
| return value == null ? this : Append(value); | |||
| return Append(value.ToString()); | |||
There was a problem hiding this comment.
The check for null is still required, otherwise the ToString() would fail.
Check here the code from the full framework.
Please follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix infinite loop in Append(object value)
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: ishvedov ivan.shvedov@gmail.com