Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small correction on SpanByte #110

Merged
merged 18 commits into from
Sep 30, 2020
Merged

Small correction on SpanByte #110

Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
251dde0
Adding SpanByte
Ellerbach Sep 30, 2020
572fc3e
adjusting comments and broken link
Ellerbach Sep 30, 2020
3d00523
Removing un necessary file
Ellerbach Sep 30, 2020
4235ba6
missing line
Ellerbach Sep 30, 2020
1410169
adjusting language version
Ellerbach Sep 30, 2020
544dc48
removing language version as not supported in the build. Removing ref…
Ellerbach Sep 30, 2020
384a8b1
removing langVersion
Ellerbach Sep 30, 2020
145c229
fixing Slice tests and Silce(x)
Ellerbach Sep 30, 2020
ea2440b
Adjusting throw conditions in slice
Ellerbach Sep 30, 2020
44391d6
Adjusting based on PR feedbacks and comments
Ellerbach Sep 30, 2020
705d371
fixing readonly
Ellerbach Sep 30, 2020
d34be4d
extra space, Length to _length
Ellerbach Sep 30, 2020
4e0f710
fixing check of lenght
Ellerbach Sep 30, 2020
e011fbb
correcxting array length check at SpenByte constructor
Ellerbach Sep 30, 2020
2068165
adjusting Slice validation check
Ellerbach Sep 30, 2020
79a8e63
correcting CopyTo
Ellerbach Sep 30, 2020
7fa2435
Merge branch 'develop' into fixingSpanByte
Ellerbach Sep 30, 2020
913af92
Merge branch 'develop' into fixingSpanByte
josesimoes Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions nanoFramework.CoreLibrary/System/SpanByte.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
//
//
// Copyright (c) .NET Foundation and Contributors
// Portions Copyright (c) Microsoft Corporation. All rights reserved.
// See LICENSE file in the project root for full license information.
Expand Down Expand Up @@ -112,14 +112,14 @@ public byte this[int index]
/// </exception>
public void CopyTo(SpanByte destination)
{
if (destination.Length < _length - _start)
if (destination.Length < _length)
{
throw new ArgumentException($"Destination too small");
}

for (int i = 0; i < _array.Length; i++)
for (int i = 0; i < _length; i++)
{
destination[i] = _array[i];
destination[i] = _array[_start + i];
}
}

Expand Down