Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editor config to solution and suppress S4200 warning #113

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Add editor config to solution and suppress S4200 warning #113

merged 1 commit into from
Oct 20, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Oct 20, 2020 •
edited
Loading

Description

  • Add config to supress S4200 warning from Sonarcloud.
  • Remove respective pragmas from code.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes
Add editor config to solutions
b7b881d 
- Add exception to S4200 warning from Sounarcloud.
@nfbot
Copy link
Member

nfbot commented Oct 20, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Add editor config to solutions Add editor config to solution and suppress S4200 warning Oct 20, 2020
@josesimoes josesimoes merged commit 055d164 into nanoframework:develop Oct 20, 2020
@josesimoes josesimoes deleted the add-editor-config branch October 20, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Config-and-Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot