Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IEnumerable implementation on String with exception throwing. #114

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

flyingoverclouds
Copy link
Contributor

@flyingoverclouds flyingoverclouds commented Nov 16, 2020

Description

Adding a basic implementation of IEnumerable on String to avoid compiler crash when foreach-ing on a String.
The GetEnumator implementation only thow a NotSupportedException in order to be compliant with .net framework practices on NotImplemented/NotSupported/PlatformNotSupported exceptions.

Motivation and Context

Iterating with foreach on a string is a common practices in c#.
But the lake of IEnumerable implement in String class generate a compilation failure with a generic error message "CSC compiler error CS7038 'Failed to emit module'" , that is very confusing for a developper, source of lost time in debugging.

This correction remove the compiler CSC7038 error on compilation, and the developper will be quickly inform during debug that the GetEnumerator is not supported. It also add documentation and intellisense informations, improving quality of developper experience.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change (update) to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Nov 16, 2020

Hi @flyingoverclouds,
😞 I'm affraid you'll have to use the PR template like the rest of us...
Make sure you've used the template and have include all the required information and fill in the appropriate details. After doing that feel free to reopen the PR. If you have questions we are here to help..

@dnfadmin
Copy link

dnfadmin commented Nov 16, 2020

CLA assistant check
All CLA requirements met.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for taking care of this.

(I've edited the PR message to comply with the template)

@josesimoes josesimoes merged commit 5ac417b into nanoframework:develop Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSC compiler error CS7038 "Failed to emit module" when using foreach() on a String
4 participants