Add IEnumerable implementation on String with exception throwing. #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a basic implementation of IEnumerable on String to avoid compiler crash when foreach-ing on a String.
The GetEnumator implementation only thow a NotSupportedException in order to be compliant with .net framework practices on NotImplemented/NotSupported/PlatformNotSupported exceptions.
Motivation and Context
Iterating with foreach on a string is a common practices in c#.
But the lake of IEnumerable implement in String class generate a compilation failure with a generic error message "CSC compiler error CS7038 'Failed to emit module'" , that is very confusing for a developper, source of lost time in debugging.
This correction remove the compiler CSC7038 error on compilation, and the developper will be quickly inform during debug that the GetEnumerator is not supported. It also add documentation and intellisense informations, improving quality of developper experience.
Types of changes
Checklist: