Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build Image #115

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Update Build Image #115

merged 1 commit into from
Dec 1, 2020

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Nov 30, 2020

Description

CICD currently uses VS2017. VS2019 will be required in future, so we should update if possible

Motivation and Context

Ensures that we dont get caught out by azure-pipelines removing VS2017 as a valid image.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Nov 30, 2020

Hi @networkfusion,

😞 If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'

@nfbot
Copy link
Member

nfbot commented Nov 30, 2020

Hi @networkfusion,

🤔 All our issues are tracked in Home repo. If this PR addresses an issue that's mentioned there, please make sure it references it using the correct pattern: nanoFramework/Home#NNNN.

@josesimoes josesimoes merged commit 2c64aae into develop Dec 1, 2020
@josesimoes josesimoes deleted the patch-cicd-image branch December 1, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CICD pipelines of all libs to use VS2019
3 participants