Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case of Double.NaN #123

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Conversation

SandorDobos
Copy link
Contributor

@SandorDobos SandorDobos commented Mar 9, 2021

Description.

  • Fix case of Double.NaN
  • Added more test cases.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Added more test cases.
@nfbot nfbot added the Type: bug label Mar 9, 2021
@networkfusion
Copy link
Member

I am guessing that the checks should be against float as well, since we dont use double out of the box?

@SandorDobos
Copy link
Contributor Author

I am guessing that the checks should be against float as well, since we dont use double out of the box?

The bug on floats leaded to Double class.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@josesimoes josesimoes changed the title Fixes issue #714 ("NaN" != "Nan") Fix case with Double.NaN Mar 9, 2021
@josesimoes josesimoes changed the title Fix case with Double.NaN Fix case of Double.NaN Mar 9, 2021
@josesimoes josesimoes merged commit 30ed071 into nanoframework:develop Mar 9, 2021
@josesimoes
Copy link
Member

I am guessing that the checks should be against float as well, since we dont use double out of the box?

The double type it's always there and exists as a CLR type. What we have optional support for are the math operation with doubles being emulated or using hardware floating point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NFUnitTestSystemLib.Number_ToString_Test test fails
4 participants