Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TimeoutException #137

Merged
merged 2 commits into from
May 19, 2021
Merged

Add TimeoutException #137

merged 2 commits into from
May 19, 2021

Conversation

Ellerbach
Copy link
Member

Adding TiemoutException

Description

Adding TiemoutException

Motivation and Context

  • To better support this exception that was categorized as Exception only
  • Because it's used in System.IO.Ports and it's coming and used in this one

How Has This Been Tested?

  • Changes made in nf-interpreter, built image, deployed image on ESP32, ran the new added test on the image, test passed and checked the output to make sure it was properly categorized

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

(need to do this to make it clear that there was a change in the interface affecting the native part too)
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes changed the title Adding TimeoutException Add TimeoutException May 19, 2021
@josesimoes josesimoes enabled auto-merge (squash) May 19, 2021 08:42
@josesimoes josesimoes merged commit d8ae458 into develop May 19, 2021
@josesimoes josesimoes deleted the develop-add-timeoutexception branch May 19, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants