Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unit tests for CoreLibrary and complete tests for Type.GetType #143

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Clean up unit tests for CoreLibrary and complete tests for Type.GetType #143

merged 2 commits into from
Jun 3, 2021

Conversation

edleno2
Copy link
Contributor

@edleno2 edleno2 commented Jun 2, 2021 •
edited by josesimoes
Loading

Description

Clean up unit tests to remove warnings, fix consistency, add test cases

  • Added new tests for Type.GetType(string) to test classes inside of classes
  • Cleaned up tests using Assert.IsType so the 1st parm is a Type and the 2nd parm is an object
  • Added a few #pragma statements to ignore certain known warning conditions
  • Removed unneeded variables to clean up warning messages
  • Renamed some variables for consistency

Motivation and Context

How Has This Been Tested?

Running unit tests on win32 for CoreLibrary

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

edleno2 and others added 2 commits June 2, 2021 13:36
@edleno2
Fixes to unit tests
34f9391 
Added new tests for Type.GetType(string) to test classes inside of classes
Cleaned up tests using Assert.IsType so the 1st parm is a Type and the 2nd parm is an object
Added a few #pragma statements to ignore certain known warning conditions
Removed unneeded variables to clean up warning messages
Renamed some variables for consistency

Fix #758
@edleno2
Merge branch 'nanoframework:develop' into develop
1a17b03
@edleno2
Copy link
Contributor Author

edleno2 commented Jun 2, 2021 •
edited
Loading

Requires native code changes to mscorlib (nanoCLR). Unit tests will fail unit native code catches up.

@edleno2 edleno2 marked this pull request as ready for review June 2, 2021 21:10
@josesimoes josesimoes merged commit 5d60cd4 into nanoframework:develop Jun 3, 2021
josesimoes
josesimoes reviewed Jun 3, 2021
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Well done. This nails it. 🥇 💯 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes left review comments

Assignees
No one assigned
Labels
Type: Unit Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edleno2 @josesimoes @nfbot