Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CoreLibrary debug type from portable to full #153

Merged
merged 1 commit into from
Jun 27, 2021

Conversation

edleno2
Copy link
Contributor

@edleno2 edleno2 commented Jun 27, 2021

This will allow mscorlib (CoreLibrary) to be debugged in Visual Studio. Likely problem was that we are limited to the framework debugger and "full" must be specified to use the older debugger with nfproj projects.

Description

Simple change of the DebugType to "full". Since the nano libraries are not core sdk they probably need to run with the framework debugger and use full for the debug type.

Motivation and Context

Allows debugging of CoreLibrary C# code when we make changes to CoreLibrary.

How Has This Been Tested?

Tested with a hello world application using CoreLibrary and System.Text. System.Text already worked - could be debugged. CoreLibrary (mscorlib) would not load symbols and could not be debugged. Changed nfproj files and now the symbols are loaded for mscorlib. Ran all unit tests for CoreLibrary.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This will allow mscorlib (CoreLibrary) to be used with debug.  Likely we are limited to the framework debugger and full must be specified to use the older debugger.
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Simple change with a huge impact. 💪👍

@josesimoes josesimoes merged commit 31e8cce into nanoframework:develop Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants