Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RuntimeFeature.IsSupported #164

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Check for DefaultImplementationsOfInterfaces.
  • Add unit tests for interfaces with default implementation.

Motivation and Context

  • Implements class to pass correct RuntimeFeature information to compiler.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Check for DefaultImplementationsOfInterfaces.
- Add unit tests for interfaces with default implementation.
@josesimoes
Copy link
Member Author

Unit Test will fail because of different assembly declaration in WIN32 CLR.

josesimoes added a commit to josesimoes/nf-interpreter that referenced this pull request Nov 23, 2021
@josesimoes josesimoes merged commit a7632de into nanoframework:develop Nov 23, 2021
@josesimoes josesimoes deleted the add-default-interface branch November 23, 2021 11:49
@josesimoes
Copy link
Member Author

@nfbot startrelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants