Fix Hashtable.CopyTo

[NemesisXB]

Description

Hashtable.CopyTo, Hashtable.Key.CopyTo and Hashtable.Value.CopyTo incorrectly used the index value as offset into the hashtable instead of the array to copy to. The index value was also incorrectly checked for out of range exception. The array length also was not checked.

Motivation and Context

• Fixes HashTable.CopyTo not working as expected Home#401

How Has This Been Tested?

Using the below test code and STM32F429I-Discovery board, the below code was tested and showed the said problem. The code was changed and tested again, this time getting the expected outcome.

using System.Collections;

namespace NFApp1
{
	public class Program
	{
		public static void Main()
		{
			Hashtable theHashtable = new Hashtable();
			theHashtable.Add(2, 'n');
			theHashtable.Add(3, 'a');
			theHashtable.Add(5, 'n');
			theHashtable.Add(7, 'o');
			theHashtable.Add(11, 'F');
			theHashtable.Add(13, 'r');
			theHashtable.Add(17, 'a');
			theHashtable.Add(19, 'm');
			theHashtable.Add(23, 'e');
			theHashtable.Add(29, 'w');
			theHashtable.Add(31, 'o');
			theHashtable.Add(37, 'r');
			theHashtable.Add(41, 'k');

			object[] c = new object[15];
			theHashtable.CopyTo(c, 2);
		}
	}
}

Screenshots

The image below shows the output window on the modified code.

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Signed-off-by: NemesisXB 485436+NemesisXB@users.noreply.github.com

[nfbot]

Hi @NemesisXB,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

[CLAassistant]

All committers have signed the CLA.

[josesimoes]

LGTM

[josesimoes]

Don't merge so we don't start a new version of core lib. Let's wait for other fixes that can be inbound.