Fix bug in FromBase64CharArray #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should deliver the new array to the native code method. Otherwise it wouldn't work for offsets != 0
|
Hi @MatthiasJentsch, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
|
@josesimoes Can you please review this? |
josesimoes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should deliver the new array to the native code method. Otherwise it wouldn't work for offsets != 0
Motivation and Context
Found that
Convert.FromBase64CharArrayis not working with an offset.How Has This Been Tested?
It's obvious that it should be implemented that way.
Types of changes
Checklist:
Signed-off-by: Matthias Jentsch info@matthias-jentsch.de