Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SortableDateTimePattern #73

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Fix SortableDateTimePattern #73

merged 1 commit into from
Jun 10, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Fix SortableDateTimePattern.

Motivation and Context

  • Was recursively accessing itself instead of the appropriate constant.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes
Fix SortableDateTimePattern
7184b11 
- Was recursivly accessing itself instead of the appropriate constant.
@nfbot
Copy link
Member

nfbot commented Jun 10, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 34e7368 into develop Jun 10, 2019
@josesimoes josesimoes deleted the josesimoes-patch-1 branch June 10, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot