Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Unix Epoch #82

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Add support for Unix Epoch #82

merged 1 commit into from
Jun 20, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add Unix Epoch constant.
  • Add methods to convert from/to Unix Epoch.
  • Bump AssemblyNativeVersion to v1.2.1.0.

Motivation and Context

  • These are available in .netcore.
  • Considering that we target IoT and network usage scenarios where Unix Epoch is widely used, it makes sense to include this in our API.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Add support for Unix Epoch
1159020 
- Add Unix Epoch constant.
- Add methods to convert from/to Unix Epoch.
- Bump AssemblyNativeVersion to v1.2.1.0.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Member

nfbot commented Jun 20, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 20, 2019
@josesimoes
Update mscorlib declaration
2faf080 
- Following nanoframework/CoreLibrary#82.
@josesimoes josesimoes mentioned this pull request Jun 20, 2019
Merged
@josesimoes
Copy link
Member Author

SonarCloud failing because of missing coverage. Ignoring.

@josesimoes josesimoes merged commit 6769c92 into nanoframework:develop Jun 20, 2019
@josesimoes josesimoes deleted the add-unix-datetime branch June 20, 2019 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot