Improvements on double and single types #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
- Add `ToSingle()` to `Convert` class. - Add `Parse()`, and `TryParse()` to `Single` class. - Add methods and properties to handle NaN and infinity to `Single` class. - Rework `ToString()` implementations in `Single` and `Double` classes to make them more efficient. - Replace customized version of `CompareTo()` on `Double` class and add it to `Single` to make is inline with .NET API. - Minor rework on code style to match guidelines. - Add missing comments for documentation for `CompareTo()` on `Double` class . - Bump AssemblyNativeVersion to 100.4.5.0. - Bump version to 1.5.1-preview. Signed-off-by: José Simões <jose.simoes@eclo.solutions>
josesimoes
force-pushed
the
work-single-double
branch
from
57d5b70 to
bee201f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ToSingle()toConvertclass.Parse(), andTryParse()toSingleclass.Singleclass.ToString()implementations inSingleandDoubleclasses to make them more efficient.CompareTo()onDoubleclass and add it toSingleto make is inline with .NET API.CompareTo()onDoubleclass .Motivation and Context
Singleclass were missing following our design decision to default native implementation to single-precision. See Implement all System.Math functions for single precision floating point values in addition to double precision Home#312.How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: José Simões jose.simoes@eclo.solutions