Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS extension does not install when using azure VS2019 hosted image. #665

Closed
networkfusion opened this issue Nov 23, 2020 · 1 comment
Closed

Comments

@networkfusion
Copy link
Member

Details about Problem

nanoFramework area: https://github.com/nanoframework/nf-tools/blob/master/AzureDevOps/TaskInstallMSBuildComponents/TaskFiles/install-nf-build-components.ps1

VS version: 2019

VS extension version: latest

Target: all

Firmware image version: all

Device capabilities output: N/A

Description

The extenstion fails to deploy to azure pipelines when the image is set to VS2019. This is due to the detection of the VM image not being recognised properly and defaulting to installing the VS2017 extension. This could be solved by setting the parameter VS_VERSION to each repo, but this is tedious and not futureproof.

Detailed repro steps so we can see the same problem

Build PR nanoframework/nanoFramework.Json#41

Other suggested things

Expected behaviour

The build would run sucessfully.

Screenshot

Additional context

Make an effort to fix the bug

After some research, it seems that https://github.com/microsoft/vswhere would be able to fix this issue. Mainly the use of the function discribed in https://github.com/microsoft/vswhere/wiki/Find-VSIXInstaller .

Additionally, it seems that this tool is installed on the hosted build agents by default: microsoft/azure-pipelines-tasks#4441

@nfbot
Copy link
Member

nfbot commented Nov 23, 2020

Hi @networkfusion,
😞 Make sure to include the complete Device Capabilities output. After doing that feel free to reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants