Add I2cTransferResult and I2cTransferStatus #11
Conversation
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
force-pushed
the
add-return-to-read-write-calls
branch
from
11d9e28 to
1b197f8
Compare
| private bool _disposed; | ||
|
|
||
| // speeds up the execution of ReadByte and WriteByte operations | ||
| private readonly byte[] _buffer; |
There was a problem hiding this comment.
Can't do...
CS8345 Field or auto-implemented property cannot be of type 'SpanByte' unless it is an instance member of a ref struct.
There was a problem hiding this comment.
hum, then it makes less sense to do this. We can tweak SpanByte to be a ref struct (it's technically one on the Span world.
| return bufferSingleOperation[0]; | ||
| lock (_syncLock) | ||
| { | ||
| var buffer = new SpanByte(_buffer); |
There was a problem hiding this comment.
this is not needed as _buffer should be a SpanByte directly
| { | ||
| var buffer = new SpanByte(_buffer); | ||
|
|
||
| NativeTransmit(null, buffer); |
There was a problem hiding this comment.
And here it's directly _buffer
| // copy value | ||
| _buffer[0] = value; | ||
|
|
||
| return NativeTransmit(new SpanByte(_buffer), null); |
There was a problem hiding this comment.
not needed, _buffer should now be a SpanByte
| _connectionSettings = settings; | ||
|
|
||
| // create the buffer | ||
| _buffer = new byte[1]; |
There was a problem hiding this comment.
This is ok, it's just than _buffer should be a SpanByte, this new allocation won't change
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: