Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding I2C Fast Mode Plus #52

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Adding I2C Fast Mode Plus #52

merged 1 commit into from
Mar 22, 2023

Conversation

Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented Mar 22, 2023

Description

  • Adding I2C Fast Mode Plus.

Motivation and Context

  • Adding I2C Fast Mode Plus which is 1 MHz for I2C.
  • For reference: https://www.i2c-bus.org/fast-mode-plus/
  • Works on most of our devices
  • Blocker identified for the STM32 devices as it seems that setting up the I2C speed is more complex than the actual code.

How Has This Been Tested?

Need to be tested for most devices

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

@nfbot nfbot added the Type: enhancement New feature or request label Mar 22, 2023
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice improvement.

@josesimoes josesimoes merged commit 1670a01 into main Mar 22, 2023
@josesimoes josesimoes deleted the add-super-fast-mode branch March 22, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants