-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create I2S Configuration Class #1
Conversation
Hi @ikivanc, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments but all up, nice design :-)
/// <summary> | ||
/// Defines channels on a I2s bus. | ||
/// </summary> | ||
public enum I2sChannelFormat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is that different from mono and stereo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For initializing I2S configuration I2sChannelFormat is required, We'll need mono and stereo when we use i2s_set_clk
We can delete I2sChannel
for now
/// </summary> | ||
public enum I2sCommunicationFormat | ||
{ | ||
/// <summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please simplify all this, there is no real reason to have multiple times the same elements with the same values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values are provided in the reference documentation for I2S communication standard format
. Do you have any suggestion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :-) Clean :-) Just keep one per value (those having the same value do have the same behavior)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StandardI2s = 0X01,
Lsb = 0x02,
Msb = 0x03,
PcmShort = 0x04,
PcmLong = 0x0C, or 0x08?
Description
Motivation and Context
Types of changes
Checklist: