Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create I2S Configuration Class #1

Merged
merged 4 commits into from
Sep 25, 2021
Merged

Create I2S Configuration Class #1

merged 4 commits into from
Sep 25, 2021

Conversation

ikivanc
Copy link
Collaborator

@ikivanc ikivanc commented Sep 24, 2021

Description

  • Added I2S Configuration Class from low-level I2S reference

Motivation and Context

  • Created I2S Configuration Class from low-level I2S reference

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Sep 24, 2021

Hi @ikivanc,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot nfbot added the Type: enhancement New feature or request label Sep 24, 2021
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments but all up, nice design :-)

/// <summary>
/// Defines channels on a I2s bus.
/// </summary>
public enum I2sChannelFormat
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is that different from mono and stereo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For initializing I2S configuration I2sChannelFormat is required, We'll need mono and stereo when we use i2s_set_clk We can delete I2sChannel for now

/// </summary>
public enum I2sCommunicationFormat
{
/// <summary>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please simplify all this, there is no real reason to have multiple times the same elements with the same values.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values are provided in the reference documentation for I2S communication standard format. Do you have any suggestion?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :-) Clean :-) Just keep one per value (those having the same value do have the same behavior)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StandardI2s = 0X01,
Lsb = 0x02,
Msb = 0x03,
PcmShort = 0x04,
PcmLong = 0x0C, or 0x08?

System.Device.I2s/I2sConnectionSettings.cs Outdated Show resolved Hide resolved
System.Device.I2s/I2sConnectionSettings.cs Outdated Show resolved Hide resolved
System.Device.I2s/I2sConnectionSettings.cs Outdated Show resolved Hide resolved
System.Device.I2s/I2sMode.cs Show resolved Hide resolved
@Ellerbach Ellerbach merged commit 122c87f into develop Sep 25, 2021
@Ellerbach Ellerbach deleted the i2s-configuration branch September 25, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants