Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement in Path #96

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Improvement in Path #96

merged 2 commits into from
Apr 8, 2024

Conversation

josesimoes
Copy link
Member

Description

  • Add GetFullPath.
  • Improve null and empty checks on several methods.

Motivation and Context

  • Adds new method required for ongoing work with FileStream.
  • Improve parameter checks.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Add GetFullPath.
- Improve null and empty checks on several methods.
@josesimoes josesimoes requested a review from Ellerbach April 5, 2024 10:56
@nfbot nfbot added Type: enhancement New feature or request Type: Unit Tests labels Apr 5, 2024
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@networkfusion
Copy link
Member

Looks good to me

Not so fast 😉
image

josesimoes

This comment was marked as outdated.

@josesimoes josesimoes enabled auto-merge (squash) April 8, 2024 06:59
Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@josesimoes josesimoes merged commit b3ea15f into main Apr 8, 2024
4 of 5 checks passed
@josesimoes josesimoes deleted the update-path branch April 8, 2024 11:43
josesimoes added a commit that referenced this pull request Apr 17, 2024
- Some wrongly added in #96.
- Add more processing of path edge cases.
- Fix several unit tests.
@josesimoes josesimoes mentioned this pull request Apr 17, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants